-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add Module Composer API #33284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Half-Shot
wants to merge
11
commits into
develop
Choose a base branch
from
hs/module-composer-api
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Module Composer API #33284
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
dde3731
Spec composer API
Half-Shot 72b2e28
Add composer api implementation
Half-Shot fd7a76f
Tests
Half-Shot 80fb9ea
Copyright
Half-Shot 5b9f885
update sigs
Half-Shot c6e6a30
cleanup
Half-Shot 4c203d3
a snap
Half-Shot 5a64f24
cleanup
Half-Shot b7a3d83
linting
Half-Shot 681cd15
Tidy up
Half-Shot c001158
Adjust
Half-Shot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /* | ||
| Copyright 2026 Element Creations Ltd. | ||
|
|
||
| SPDX-License-Identifier: AGPL-3.0-only OR GPL-3.0-only OR LicenseRef-Element-Commercial | ||
| Please see LICENSE files in the repository root for full details. | ||
| */ | ||
|
|
||
| import { type ComposerApi as ModuleComposerApi } from "@element-hq/element-web-module-api"; | ||
|
|
||
| import type { MatrixDispatcher } from "../dispatcher/dispatcher"; | ||
| import { Action } from "../dispatcher/actions"; | ||
| import type { ComposerInsertPayload } from "../dispatcher/payloads/ComposerInsertPayload"; | ||
|
|
||
| export class ComposerApi implements ModuleComposerApi { | ||
| public constructor(private readonly dispatcher: MatrixDispatcher) {} | ||
|
|
||
| public insertTextIntoComposer(text: string): void { | ||
| this.dispatcher.dispatch({ | ||
| action: Action.ComposerInsert, | ||
| text, | ||
| } satisfies ComposerInsertPayload); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| /* | ||
| Copyright 2026 Element Creations Ltd. | ||
|
|
||
| SPDX-License-Identifier: AGPL-3.0-only OR GPL-3.0-only OR LicenseRef-Element-Commercial | ||
| Please see LICENSE files in the repository root for full details. | ||
| */ | ||
|
|
||
| import { Action } from "../../../src/dispatcher/actions"; | ||
| import type { MatrixDispatcher } from "../../../src/dispatcher/dispatcher"; | ||
| import { ComposerApi } from "../../../src/modules/ComposerApi"; | ||
|
|
||
| describe("ComposerApi", () => { | ||
| it("should be able to insert text via insertTextIntoComposer()", () => { | ||
| const dispatcher = { | ||
| dispatch: jest.fn(), | ||
| } as unknown as MatrixDispatcher; | ||
| const api = new ComposerApi(dispatcher); | ||
| api.insertTextIntoComposer("Hello world"); | ||
| expect(dispatcher.dispatch).toHaveBeenCalledWith({ | ||
| action: Action.ComposerInsert, | ||
| text: "Hello world", | ||
| }); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How useful is this Module API really if you don't know what mode your user's composer is in?
one of 4:
Depending on which option the user has this Module API will yield very different results, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just make this a plaintext function that's common between all 4 of those kinds. If future module makers want to markdown and go nuts, they can add that functionality. Hopefully in a world where we have fewer composers.