Add auto-play consecutive voice messages in timeline#6454
Add auto-play consecutive voice messages in timeline#6454kalix127 wants to merge 4 commits intoelement-hq:developfrom
Conversation
|
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
|
bxdxnn
left a comment
There was a problem hiding this comment.
LGTM, but the common behavior is to also play a sound between messages before playing them.
I know, in fact I asked for feedback and suggestions on which sound to use. Honestly, the options are endless. |
|
In the meantime, I've added code to play a sound when it moves on to the next audio recording. Right now, it uses the same default notification sound, but all you have to do is replace it with a different sound, and then it's all set. @americanrefugee , do you have any suggestions for a sound to use? |
Actually I think @amshakal would be a better person to ask since she reviewed the notification sounds in general recently. |
Content
Add auto-play for consecutive voice messages in the timeline. When a voice message finishes playing, if the next chronological message is also a voice message, it automatically starts playing. The chain continues until a non-voice message is encountered or the end of the timeline is reached.
Key changes:
VoiceMessageAutoplayManagerinterface (voiceplayer API) andDefaultVoiceMessageAutoplayManagerimplementation (voiceplayer impl, RoomScope singleton)MediaPlayer.stateforisEndedtransitions and triggers playback of the next consecutive voice messageVoiceMessagePresenterlistens for reset requests and cancels autoplay on manual pauseTimelinePresenterfeeds current timeline items to the autoplay manager on each updateMotivation and context
Closes #4618
This is a standard feature in almost every modern messaging app.
Screenshots / GIFs
Tests
Tested devices
Checklist
Open questions
@jmartinesp