Support replying to messages with voice recordings#6464
Open
kalix127 wants to merge 6 commits intoelement-hq:developfrom
Open
Support replying to messages with voice recordings#6464kalix127 wants to merge 6 commits intoelement-hq:developfrom
kalix127 wants to merge 6 commits intoelement-hq:developfrom
Conversation
|
I like it! LGTM |
ganfra
reviewed
Mar 27, 2026
...ndroid/features/messages/impl/voicemessages/composer/DefaultVoiceMessageComposerPresenter.kt
Outdated
Show resolved
Hide resolved
bxdxnn
approved these changes
Apr 1, 2026
.../textcomposer/impl/src/main/kotlin/io/element/android/libraries/textcomposer/TextComposer.kt
Outdated
Show resolved
Hide resolved
kalix127
added a commit
to kalix127/element-x-android
that referenced
this pull request
Apr 2, 2026
bmarty
reviewed
Apr 2, 2026
.../textcomposer/impl/src/main/kotlin/io/element/android/libraries/textcomposer/TextComposer.kt
Outdated
Show resolved
Hide resolved
bmarty
reviewed
Apr 3, 2026
| onRequestFocus() | ||
| } | ||
| previousVoiceMessageState = voiceMessageState | ||
| } |
Member
There was a problem hiding this comment.
Do you think it is a good idea to show the keyboard when the voice message is just send? It will annoy the users who want to send several voice message in a row.
(Also this change is out of scope of this PR)
Contributor
Author
There was a problem hiding this comment.
Users can send multiple voice messages in a row, with or without the keyboard open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
Add support for replying to messages with a voice recording. The infrastructure already existed end-to-end (
MediaSender.sendVoiceMessage()acceptsinReplyToEventId), but the voice message presenter was not wiring it through.Changes:
mediaSender.sendVoiceMessage()TextInputBoxwrapperMotivation and context
Closes #4053
Users could not reply to a message with a voice recording. Tapping "Reply" and then recording audio would send the voice message without the reply relation, and the reply banner would disappear during recording.
Screenshots / GIFs
video-3.mp4
Tests
Tested devices
Checklist