Skip to content

Add confirmation dialog when inviting users with unknown identities#6523

Draft
kaylendog wants to merge 3 commits intodevelopfrom
kaylendog/history-sharing/prompt
Draft

Add confirmation dialog when inviting users with unknown identities#6523
kaylendog wants to merge 3 commits intodevelopfrom
kaylendog/history-sharing/prompt

Conversation

@kaylendog
Copy link
Copy Markdown
Contributor

@kaylendog kaylendog commented Apr 2, 2026

Content

Introduces a new confirmation modal that appears when a user attempts to invite users who's cryptographpic identities have not been cached.

Part of element-hq/element-meta#3163

Motivation and context

It might be quite easy to accidentally typo a user ID, and invite a user that we haven't previously interacted with. When this happens, we won't have a record of their identity, so it might be an easy attack for the server to replace their identity with an attacker-controlled identity.

While the initial motivation behind these changes was to prevent sending historic room keys to members we might not mean to, there are more general arguments to be made.

Screenshots / GIFs

features invitepeople impl_InvitePeopleView_Day_10_en features invitepeople impl_InvitePeopleView_Night_10_en

Tests

TODO

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • This PR was made with the help of AI:
    • Yes. In this case, please request a review by Copilot.
    • No.
  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly defines what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@ElementBot
Copy link
Copy Markdown
Collaborator

Fails
🚫

Please add a PR- label to categorise the changelog entry.

Generated by 🚫 dangerJS against c2b0cb1

@kaylendog kaylendog self-assigned this Apr 2, 2026
@kaylendog kaylendog added the PR-Wip For anything that isn't ready to ship and will be enabled at a later date label Apr 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/PqRJwG

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 2, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Wip For anything that isn't ready to ship and will be enabled at a later date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants