Open
Conversation
| - name: Run tests | ||
| run: swift run -q tools ci server-login-tests | ||
| env: | ||
| INTEGRATION_TESTS_HOST: ${{ secrets[matrix.host_secret] }} |
Check warning
Code scanning / zizmor
excessively provisioned secrets Warning
| run: swift run -q tools ci server-login-tests | ||
| env: | ||
| INTEGRATION_TESTS_HOST: ${{ secrets[matrix.host_secret] }} | ||
| INTEGRATION_TESTS_USERNAME: ${{ secrets[matrix.username_secret] }} |
Check warning
Code scanning / zizmor
excessively provisioned secrets Warning
| env: | ||
| INTEGRATION_TESTS_HOST: ${{ secrets[matrix.host_secret] }} | ||
| INTEGRATION_TESTS_USERNAME: ${{ secrets[matrix.username_secret] }} | ||
| INTEGRATION_TESTS_PASSWORD: ${{ secrets[matrix.password_secret] }} |
Check warning
Code scanning / zizmor
excessively provisioned secrets Warning
1f366a7 to
029c41b
Compare
Member
Author
❌ 2 Tests Failed:
View the top 1 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Adds a generic ServerLoginTests class with a single testLogin method that reads the server host, username and password from environment variables. The login helper auto-detects whether the server uses a Keycloak identity provider and adapts the web UI interaction accordingly, so the same test works against any OIDC server. A new server-login-tests CLI command runs only this test class. A GitHub Actions matrix job feeds server-specific secrets as the standard INTEGRATION_TESTS_HOST/USERNAME/PASSWORD variables, making it trivial to extend coverage to additional servers by adding new matrix entries.
0d9e3b9 to
42288a1
Compare
de24ea3 to
a98d41d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds a
ServerLoginTestsclass with a singletestLoginmethod that verifies login works against a configurable server.The
loginhelper auto-detects whether the server uses a Keycloak identity provider (via the "Continue with Keycloak" link) and adapts the web UI interaction accordingly, so the same test works against any OIDC server. It also handles stale MAS sessions by looking for "Sign out" or "Use another account" buttons before attempting login.A new
server-login-testsCLI command runs only this test class. A GitHub Actions matrix job in the integration tests workflow feeds server-specific secrets as the standardINTEGRATION_TESTS_HOST/USERNAME/PASSWORDvariables. The matrix currently covers three servers: default, lts, lts-1.