Skip to content

Notification Decoration Revised#5312

Draft
amshakal wants to merge 2 commits intodevelopfrom
amsha/notification-revised
Draft

Notification Decoration Revised#5312
amshakal wants to merge 2 commits intodevelopfrom
amsha/notification-revised

Conversation

@amshakal
Copy link
Copy Markdown
Member

@amshakal amshakal commented Mar 27, 2026

  1. I removed the grey dots for when there is activity in rooms set to mentions or mute. I
  2. For all unread rooms, I made the message preview text bold for better legibility
  3. For rooms with no unreads, I made the font weight regular, again for legibility
Screenshot 2026-03-30 at 16 31 26

1. I removed the grey dots for when there is activity in rooms set to mentions or mute. I
2. For all unread rooms, I made the message preview text bold for better legibility
3. For rooms with no unreads, I made the font weight regular, again for legibility
@amshakal amshakal requested a review from a team as a code owner March 27, 2026 13:57
@amshakal amshakal requested review from stefanceriu and removed request for a team March 27, 2026 13:57
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
910 2 908 0
View the top 2 failed test(s) by shortest run time
HomeScreenRoomTests::mentionAndKeywordsUnhighlightedDot()
Stack Traces | 1s run time
Expectation failed: (room.badges → Badges(isDotShown: false, isMentionShown: false, isMuteShown: false, isCallShown: false)).isDotShown → false (HomeScreenRoomTests.swift:167)
::unhighlightedDot()
Stack Traces | 328s run time
Expectation failed: (room.badges → Badges(isDotShown: false, isMentionShown: false, isMuteShown: false, isCallShown: false)).isDotShown → false (HomeScreenRoomTests.swift:95)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@stefanceriu stefanceriu marked this pull request as draft March 30, 2026 13:43
@stefanceriu stefanceriu removed their request for review March 30, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants