Closed
Conversation
6de8dff to
59cc473
Compare
59cc473 to
e39303c
Compare
…iewModel and the LiveLocationRoomTimelineItemView
a8a0ec7 to
858c1e6
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #5333 +/- ##
===========================================
- Coverage 74.58% 74.49% -0.10%
===========================================
Files 800 800
Lines 53498 53636 +138
===========================================
+ Hits 39904 39958 +54
- Misses 13594 13678 +84
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements inside the LiveLocationManager the following functions
It also implements a store that keeps track of what are the rooms this device is sending LLS to, in this way in case of a crash, kill or reopen we can restore the LLS updates.
We also try to stop events once they have expired in conformance with the MSC.
It's important to note that this is a best effort thing, if it's not possible we don't try again (usually clients implement an internal check to consider an LLS expired, so that's generally fine).
To review commit by commit.
Also the send functions will not work properly on the current SDK release, since we need a fix for the sync over the
beaconInfoevent, which is being worked on here: matrix-org/matrix-rust-sdk#6385