Skip to content

Implement live location sharing start and stop actions in the UI#5349

Merged
Velin92 merged 3 commits intodevelopfrom
mauroromito/start_and_stop_ui
Apr 3, 2026
Merged

Implement live location sharing start and stop actions in the UI#5349
Velin92 merged 3 commits intodevelopfrom
mauroromito/start_and_stop_ui

Conversation

@Velin92
Copy link
Copy Markdown
Member

@Velin92 Velin92 commented Apr 2, 2026

Okay so this PR finally connects the CTAs that were already in the app about LLS with its manager.

  • It adds a bunch of alerts after the permissions are determined when selecting the live location sharing option from the location screen (a disclaimer about your privacy + a duration selector) and then calls the start function for the room
  • it connects the stop function to the live location timeline item view stop button
  • Adds a bunch of tests to the LocationSharingScreenViewModel

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 95.45455% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.49%. Comparing base (d9a480b) to head (f74388a).
⚠️ Report is 5 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...cationSharing/LocationSharingScreenViewModel.swift 97.67% 1 Missing ⚠️
...X/Sources/Screens/Timeline/TimelineViewModel.swift 50.00% 1 Missing ⚠️
...melineItemViews/LiveLocationRoomTimelineView.swift 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5349      +/-   ##
===========================================
+ Coverage    74.46%   74.49%   +0.03%     
===========================================
  Files          800      800              
  Lines        53590    53639      +49     
===========================================
+ Hits         39906    39960      +54     
+ Misses       13684    13679       -5     
Flag Coverage Δ
unittests 64.47% <95.45%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 force-pushed the mauroromito/start_and_stop_ui branch from dd9de9a to 061f31a Compare April 3, 2026 10:49
@Velin92 Velin92 marked this pull request as ready for review April 3, 2026 10:50
@Velin92 Velin92 requested a review from a team as a code owner April 3, 2026 10:50
@Velin92 Velin92 force-pushed the mauroromito/start_and_stop_ui branch from 061f31a to f74388a Compare April 3, 2026 10:57
@Velin92 Velin92 added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Apr 3, 2026
Copy link
Copy Markdown
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice 👍

@Velin92 Velin92 merged commit 93a6917 into develop Apr 3, 2026
14 of 16 checks passed
@Velin92 Velin92 deleted the mauroromito/start_and_stop_ui branch April 3, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-wip for anything that isn't ready to ship and will be enabled at a later date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants