The updated matrixAuthenticationService.nodeSelector value does not completely override the old one.

[watermelon0339]

Describe the bug
When I updated matrixAuthenticationService.nodeSelector, then helm upgrade xxxx.
The final value of matrixAuthenticationService.nodeSelector is a merge of the new and old settings, rather than a replacement.
This caused the deployment of matrix-authentication-service to fail.

To Reproduce

1. Edit ~/ess-config-values/hostnames.yaml

    matrixAuthenticationService:
         nodeSelector:
           kubernetes.io/hostname: master

2. helm upgrade xxxxx, this succeeded.
3. Edit ~/ess-config-values/hostnames.yaml again

    matrixAuthenticationService:
         nodeSelector:
           kubernetes.io/hostname: worker

4. helm upgrade xxxxx failed because of no nodes match the nodeSelector(kubernetes.io/hostname: worker+kubernetes.io/hostname: master)

Expected behavior
The updated new matrixAuthenticationService.nodeSelector should completely override the old one.

ess-helm
Version: matrix-stack-25.6.2

[benbz]

I'm afraid I can't reproduce this:

$ helm upgrade -i -n ess ess charts/matrix-stack -f charts/matrix-stack/ci/matrix-authentication-service-minimal-values.yaml --set=matrixAuthenticationService.nodeSelector."kubernetes\.io/hostname"=master
Release "ess" does not exist. Installing it now.
NAME: ess
LAST DEPLOYED: Mon Jun 30 09:33:14 2025
NAMESPACE: ess
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
ESS Community 25.6.3-dev
...

$ kubectl -n ess get deployment/ess-matrix-authentication-service -o jsonpath={.spec.template.spec.nodeSelector}
{"kubernetes.io/hostname":"master"}

$ helm upgrade -i -n ess ess charts/matrix-stack -f charts/matrix-stack/ci/matrix-authentication-service-minimal-values.yaml --set=matrixAuthenticationService.nodeSelector."kubernetes\.io/hostname"=worker
Release "ess" has been upgraded. Happy Helming!
NAME: ess
LAST DEPLOYED: Mon Jun 30 09:34:15 2025
NAMESPACE: ess
STATUS: deployed
REVISION: 2
TEST SUITE: None
NOTES:
ESS Community 25.6.3-dev
...

$ kubectl -n ess get deployment/ess-matrix-authentication-service -o jsonpath={.spec.template.spec.nodeSelector}                                                                                            
{"kubernetes.io/hostname":"worker"}

Please can you provide more details on your helm upgrade commands.

The chart itself isn't doing anything interesting in the configured nodeSelector, it simply passes through what you provide in the values. As far as I'm aware Helm doesn't provide chart authors any mechanism to get the values from previous helm install/helm upgrade runs so we couldn't merge previous values even if we wanted to

[watermelon0339]

After retrying today, the problem seems to be fixed — the mas nodeSelector is correctly applied as expected.