matrix-rtc: fix services monitors#569
Merged
gaelgatelement merged 6 commits intomainfrom Jun 30, 2025
Merged
Conversation
dyff of changes in rendered templates of CI manifestsmatrix-rtc-checkov-values.yaml@@ spec.ports @@
# v1/Service/ess-ci/release-name-matrix-rtc-sfu
! + one list entry added:
+ - name: metrics
+ port: 6789
+ targetPort: metrics
@@ servicemonitor-release-name-matrix-rtc-authorisation-service.yaml @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-authorisation-service
! - one file removed
- apiVersion: monitoring.coreos.com/v1
- kind: ServiceMonitor
- metadata:
- labels:
- helm.sh/chart: "matrix-stack-25.6.3-dev"
- app.kubernetes.io/managed-by: Helm
- app.kubernetes.io/part-of: matrix-stack
- app.kubernetes.io/component: matrix-rtc-authorisation-service
- app.kubernetes.io/name: matrix-rtc-authorisation-service
- app.kubernetes.io/instance: release-name-matrix-rtc-authorisation-service
- app.kubernetes.io/version: "0.2.3"
- name: release-name-matrix-rtc-authorisation-service
- namespace: ess-ci
@@ spec.endpoints.0.port @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-sfu
! ± value change
- http
+ metrics
matrix-rtc-exposed-services-values.yaml@@ spec.ports @@
# v1/Service/ess-ci/release-name-matrix-rtc-sfu
! + one list entry added:
+ - name: metrics
+ port: 6789
+ targetPort: metrics
@@ servicemonitor-release-name-matrix-rtc-authorisation-service.yaml @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-authorisation-service
! - one file removed
- apiVersion: monitoring.coreos.com/v1
- kind: ServiceMonitor
- metadata:
- labels:
- helm.sh/chart: "matrix-stack-25.6.3-dev"
- app.kubernetes.io/managed-by: Helm
- app.kubernetes.io/part-of: matrix-stack
- app.kubernetes.io/component: matrix-rtc-authorisation-service
- app.kubernetes.io/name: matrix-rtc-authorisation-service
- app.kubernetes.io/instance: release-name-matrix-rtc-authorisation-service
- app.kubernetes.io/version: "0.2.3"
- name: release-name-matrix-rtc-authorisation-service
- namespace: ess-ci
@@ spec.endpoints.0.port @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-sfu
! ± value change
- http
+ metrics
matrix-rtc-external-livekit-secrets-externally-values.yaml@@ servicemonitor-release-name-matrix-rtc-authorisation-service.yaml @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-authorisation-service
! - one file removed
- apiVersion: monitoring.coreos.com/v1
- kind: ServiceMonitor
- metadata:
- labels:
- helm.sh/chart: "matrix-stack-25.6.3-dev"
- app.kubernetes.io/managed-by: Helm
- app.kubernetes.io/part-of: matrix-stack
- app.kubernetes.io/component: matrix-rtc-authorisation-service
- app.kubernetes.io/name: matrix-rtc-authorisation-service
- app.kubernetes.io/instance: release-name-matrix-rtc-authorisation-service
- app.kubernetes.io/version: "0.2.3"
- name: release-name-matrix-rtc-authorisation-service
- namespace: ess-ci
matrix-rtc-external-livekit-secrets-in-helm-values.yaml@@ servicemonitor-release-name-matrix-rtc-authorisation-service.yaml @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-authorisation-service
! - one file removed
- apiVersion: monitoring.coreos.com/v1
- kind: ServiceMonitor
- metadata:
- labels:
- helm.sh/chart: "matrix-stack-25.6.3-dev"
- app.kubernetes.io/managed-by: Helm
- app.kubernetes.io/part-of: matrix-stack
- app.kubernetes.io/component: matrix-rtc-authorisation-service
- app.kubernetes.io/name: matrix-rtc-authorisation-service
- app.kubernetes.io/instance: release-name-matrix-rtc-authorisation-service
- app.kubernetes.io/version: "0.2.3"
- name: release-name-matrix-rtc-authorisation-service
- namespace: ess-ci
matrix-rtc-host-mode-values.yaml@@ spec.ports @@
# v1/Service/ess-ci/release-name-matrix-rtc-sfu
! + one list entry added:
+ - name: metrics
+ port: 6789
+ targetPort: metrics
@@ servicemonitor-release-name-matrix-rtc-authorisation-service.yaml @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-authorisation-service
! - one file removed
- apiVersion: monitoring.coreos.com/v1
- kind: ServiceMonitor
- metadata:
- labels:
- helm.sh/chart: "matrix-stack-25.6.3-dev"
- app.kubernetes.io/managed-by: Helm
- app.kubernetes.io/part-of: matrix-stack
- app.kubernetes.io/component: matrix-rtc-authorisation-service
- app.kubernetes.io/name: matrix-rtc-authorisation-service
- app.kubernetes.io/instance: release-name-matrix-rtc-authorisation-service
- app.kubernetes.io/version: "0.2.3"
- name: release-name-matrix-rtc-authorisation-service
- namespace: ess-ci
@@ spec.endpoints.0.port @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-sfu
! ± value change
- http
+ metrics
matrix-rtc-minimal-values.yaml@@ spec.ports @@
# v1/Service/ess-ci/release-name-matrix-rtc-sfu
! + one list entry added:
+ - name: metrics
+ port: 6789
+ targetPort: metrics
@@ servicemonitor-release-name-matrix-rtc-authorisation-service.yaml @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-authorisation-service
! - one file removed
- apiVersion: monitoring.coreos.com/v1
- kind: ServiceMonitor
- metadata:
- labels:
- helm.sh/chart: "matrix-stack-25.6.3-dev"
- app.kubernetes.io/managed-by: Helm
- app.kubernetes.io/part-of: matrix-stack
- app.kubernetes.io/component: matrix-rtc-authorisation-service
- app.kubernetes.io/name: matrix-rtc-authorisation-service
- app.kubernetes.io/instance: release-name-matrix-rtc-authorisation-service
- app.kubernetes.io/version: "0.2.3"
- name: release-name-matrix-rtc-authorisation-service
- namespace: ess-ci
@@ spec.endpoints.0.port @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-sfu
! ± value change
- http
+ metrics
matrix-rtc-secrets-externally-values.yaml@@ spec.ports @@
# v1/Service/ess-ci/release-name-matrix-rtc-sfu
! + one list entry added:
+ - name: metrics
+ port: 6789
+ targetPort: metrics
@@ servicemonitor-release-name-matrix-rtc-authorisation-service.yaml @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-authorisation-service
! - one file removed
- apiVersion: monitoring.coreos.com/v1
- kind: ServiceMonitor
- metadata:
- labels:
- helm.sh/chart: "matrix-stack-25.6.3-dev"
- app.kubernetes.io/managed-by: Helm
- app.kubernetes.io/part-of: matrix-stack
- app.kubernetes.io/component: matrix-rtc-authorisation-service
- app.kubernetes.io/name: matrix-rtc-authorisation-service
- app.kubernetes.io/instance: release-name-matrix-rtc-authorisation-service
- app.kubernetes.io/version: "0.2.3"
- name: release-name-matrix-rtc-authorisation-service
- namespace: ess-ci
@@ spec.endpoints.0.port @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-sfu
! ± value change
- http
+ metrics
matrix-rtc-secrets-in-helm-values.yaml@@ spec.ports @@
# v1/Service/ess-ci/release-name-matrix-rtc-sfu
! + one list entry added:
+ - name: metrics
+ port: 6789
+ targetPort: metrics
@@ servicemonitor-release-name-matrix-rtc-authorisation-service.yaml @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-authorisation-service
! - one file removed
- apiVersion: monitoring.coreos.com/v1
- kind: ServiceMonitor
- metadata:
- labels:
- helm.sh/chart: "matrix-stack-25.6.3-dev"
- app.kubernetes.io/managed-by: Helm
- app.kubernetes.io/part-of: matrix-stack
- app.kubernetes.io/component: matrix-rtc-authorisation-service
- app.kubernetes.io/name: matrix-rtc-authorisation-service
- app.kubernetes.io/instance: release-name-matrix-rtc-authorisation-service
- app.kubernetes.io/version: "0.2.3"
- name: release-name-matrix-rtc-authorisation-service
- namespace: ess-ci
@@ spec.endpoints.0.port @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-sfu
! ± value change
- http
+ metrics
pytest-matrix-rtc-standalone-values.yaml@@ metadata @@
# apps/v1/Deployment/ess-ci/release-name-matrix-rtc-authorisation-service
! + one map entry added:
+ annotations:
+ has-no-service-monitor: "true"
@@ spec.template.metadata @@
# apps/v1/Deployment/ess-ci/release-name-matrix-rtc-authorisation-service
! + one map entry added:
+ annotations:
+ has-no-service-monitor: "true"
@@ spec.ports @@
# v1/Service/ess-ci/release-name-matrix-rtc-sfu
! + one list entry added:
+ - name: metrics
+ port: 6789
+ targetPort: metrics
@@ servicemonitor-release-name-matrix-rtc-authorisation-service.yaml @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-authorisation-service
! - one file removed
- apiVersion: monitoring.coreos.com/v1
- kind: ServiceMonitor
- metadata:
- labels:
- helm.sh/chart: "matrix-stack-25.6.3-dev"
- app.kubernetes.io/managed-by: Helm
- app.kubernetes.io/part-of: matrix-stack
- app.kubernetes.io/component: matrix-rtc-authorisation-service
- app.kubernetes.io/name: matrix-rtc-authorisation-service
- app.kubernetes.io/instance: release-name-matrix-rtc-authorisation-service
- app.kubernetes.io/version: "0.2.3"
- name: release-name-matrix-rtc-authorisation-service
- namespace: ess-ci
@@ spec.endpoints.0.port @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-sfu
! ± value change
- http
+ metrics
pytest-matrix-rtc-synapse-wellknown-values.yaml@@ metadata @@
# apps/v1/Deployment/ess-ci/release-name-matrix-rtc-authorisation-service
! + one map entry added:
+ annotations:
+ has-no-service-monitor: "true"
@@ spec.template.metadata @@
# apps/v1/Deployment/ess-ci/release-name-matrix-rtc-authorisation-service
! + one map entry added:
+ annotations:
+ has-no-service-monitor: "true"
@@ spec.ports @@
# v1/Service/ess-ci/release-name-matrix-rtc-sfu
! + one list entry added:
+ - name: metrics
+ port: 6789
+ targetPort: metrics
@@ servicemonitor-release-name-matrix-rtc-authorisation-service.yaml @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-authorisation-service
! - one file removed
- apiVersion: monitoring.coreos.com/v1
- kind: ServiceMonitor
- metadata:
- labels:
- helm.sh/chart: "matrix-stack-25.6.3-dev"
- app.kubernetes.io/managed-by: Helm
- app.kubernetes.io/part-of: matrix-stack
- app.kubernetes.io/component: matrix-rtc-authorisation-service
- app.kubernetes.io/name: matrix-rtc-authorisation-service
- app.kubernetes.io/instance: release-name-matrix-rtc-authorisation-service
- app.kubernetes.io/version: "0.2.3"
- name: release-name-matrix-rtc-authorisation-service
- namespace: ess-ci
@@ spec.endpoints.0.port @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-sfu
! ± value change
- http
+ metrics
quick-setup-certificates-pg-external-values.yaml@@ spec.ports @@
# v1/Service/ess-ci/release-name-matrix-rtc-sfu
! + one list entry added:
+ - name: metrics
+ port: 6789
+ targetPort: metrics
@@ servicemonitor-release-name-matrix-rtc-authorisation-service.yaml @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-authorisation-service
! - one file removed
- apiVersion: monitoring.coreos.com/v1
- kind: ServiceMonitor
- metadata:
- labels:
- helm.sh/chart: "matrix-stack-25.6.3-dev"
- app.kubernetes.io/managed-by: Helm
- app.kubernetes.io/part-of: matrix-stack
- app.kubernetes.io/component: matrix-rtc-authorisation-service
- app.kubernetes.io/name: matrix-rtc-authorisation-service
- app.kubernetes.io/instance: release-name-matrix-rtc-authorisation-service
- app.kubernetes.io/version: "0.2.3"
- name: release-name-matrix-rtc-authorisation-service
- namespace: ess-ci
@@ spec.endpoints.0.port @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-sfu
! ± value change
- http
+ metrics
quick-setup-certificates-pg-with-helm-values.yaml@@ spec.ports @@
# v1/Service/ess-ci/release-name-matrix-rtc-sfu
! + one list entry added:
+ - name: metrics
+ port: 6789
+ targetPort: metrics
@@ servicemonitor-release-name-matrix-rtc-authorisation-service.yaml @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-authorisation-service
! - one file removed
- apiVersion: monitoring.coreos.com/v1
- kind: ServiceMonitor
- metadata:
- labels:
- helm.sh/chart: "matrix-stack-25.6.3-dev"
- app.kubernetes.io/managed-by: Helm
- app.kubernetes.io/part-of: matrix-stack
- app.kubernetes.io/component: matrix-rtc-authorisation-service
- app.kubernetes.io/name: matrix-rtc-authorisation-service
- app.kubernetes.io/instance: release-name-matrix-rtc-authorisation-service
- app.kubernetes.io/version: "0.2.3"
- name: release-name-matrix-rtc-authorisation-service
- namespace: ess-ci
@@ spec.endpoints.0.port @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-sfu
! ± value change
- http
+ metrics
quick-setup-external-cert-pg-external-values.yaml@@ spec.ports @@
# v1/Service/ess-ci/release-name-matrix-rtc-sfu
! + one list entry added:
+ - name: metrics
+ port: 6789
+ targetPort: metrics
@@ servicemonitor-release-name-matrix-rtc-authorisation-service.yaml @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-authorisation-service
! - one file removed
- apiVersion: monitoring.coreos.com/v1
- kind: ServiceMonitor
- metadata:
- labels:
- helm.sh/chart: "matrix-stack-25.6.3-dev"
- app.kubernetes.io/managed-by: Helm
- app.kubernetes.io/part-of: matrix-stack
- app.kubernetes.io/component: matrix-rtc-authorisation-service
- app.kubernetes.io/name: matrix-rtc-authorisation-service
- app.kubernetes.io/instance: release-name-matrix-rtc-authorisation-service
- app.kubernetes.io/version: "0.2.3"
- name: release-name-matrix-rtc-authorisation-service
- namespace: ess-ci
@@ spec.endpoints.0.port @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-sfu
! ± value change
- http
+ metrics
quick-setup-external-cert-pg-with-helm-values.yaml@@ spec.ports @@
# v1/Service/ess-ci/release-name-matrix-rtc-sfu
! + one list entry added:
+ - name: metrics
+ port: 6789
+ targetPort: metrics
@@ servicemonitor-release-name-matrix-rtc-authorisation-service.yaml @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-authorisation-service
! - one file removed
- apiVersion: monitoring.coreos.com/v1
- kind: ServiceMonitor
- metadata:
- labels:
- helm.sh/chart: "matrix-stack-25.6.3-dev"
- app.kubernetes.io/managed-by: Helm
- app.kubernetes.io/part-of: matrix-stack
- app.kubernetes.io/component: matrix-rtc-authorisation-service
- app.kubernetes.io/name: matrix-rtc-authorisation-service
- app.kubernetes.io/instance: release-name-matrix-rtc-authorisation-service
- app.kubernetes.io/version: "0.2.3"
- name: release-name-matrix-rtc-authorisation-service
- namespace: ess-ci
@@ spec.endpoints.0.port @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-sfu
! ± value change
- http
+ metrics
quick-setup-letsencrypt-pg-external-values.yaml@@ spec.ports @@
# v1/Service/ess-ci/release-name-matrix-rtc-sfu
! + one list entry added:
+ - name: metrics
+ port: 6789
+ targetPort: metrics
@@ servicemonitor-release-name-matrix-rtc-authorisation-service.yaml @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-authorisation-service
! - one file removed
- apiVersion: monitoring.coreos.com/v1
- kind: ServiceMonitor
- metadata:
- labels:
- helm.sh/chart: "matrix-stack-25.6.3-dev"
- app.kubernetes.io/managed-by: Helm
- app.kubernetes.io/part-of: matrix-stack
- app.kubernetes.io/component: matrix-rtc-authorisation-service
- app.kubernetes.io/name: matrix-rtc-authorisation-service
- app.kubernetes.io/instance: release-name-matrix-rtc-authorisation-service
- app.kubernetes.io/version: "0.2.3"
- name: release-name-matrix-rtc-authorisation-service
- namespace: ess-ci
@@ spec.endpoints.0.port @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-sfu
! ± value change
- http
+ metrics
quick-setup-letsencrypt-pg-with-helm-values.yaml@@ spec.ports @@
# v1/Service/ess-ci/release-name-matrix-rtc-sfu
! + one list entry added:
+ - name: metrics
+ port: 6789
+ targetPort: metrics
@@ servicemonitor-release-name-matrix-rtc-authorisation-service.yaml @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-authorisation-service
! - one file removed
- apiVersion: monitoring.coreos.com/v1
- kind: ServiceMonitor
- metadata:
- labels:
- helm.sh/chart: "matrix-stack-25.6.3-dev"
- app.kubernetes.io/managed-by: Helm
- app.kubernetes.io/part-of: matrix-stack
- app.kubernetes.io/component: matrix-rtc-authorisation-service
- app.kubernetes.io/name: matrix-rtc-authorisation-service
- app.kubernetes.io/instance: release-name-matrix-rtc-authorisation-service
- app.kubernetes.io/version: "0.2.3"
- name: release-name-matrix-rtc-authorisation-service
- namespace: ess-ci
@@ spec.endpoints.0.port @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-sfu
! ± value change
- http
+ metrics
quick-setup-wildcard-cert-pg-external-values.yaml@@ spec.ports @@
# v1/Service/ess-ci/release-name-matrix-rtc-sfu
! + one list entry added:
+ - name: metrics
+ port: 6789
+ targetPort: metrics
@@ servicemonitor-release-name-matrix-rtc-authorisation-service.yaml @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-authorisation-service
! - one file removed
- apiVersion: monitoring.coreos.com/v1
- kind: ServiceMonitor
- metadata:
- labels:
- helm.sh/chart: "matrix-stack-25.6.3-dev"
- app.kubernetes.io/managed-by: Helm
- app.kubernetes.io/part-of: matrix-stack
- app.kubernetes.io/component: matrix-rtc-authorisation-service
- app.kubernetes.io/name: matrix-rtc-authorisation-service
- app.kubernetes.io/instance: release-name-matrix-rtc-authorisation-service
- app.kubernetes.io/version: "0.2.3"
- name: release-name-matrix-rtc-authorisation-service
- namespace: ess-ci
@@ spec.endpoints.0.port @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-sfu
! ± value change
- http
+ metrics
quick-setup-wildcard-cert-pg-with-helm-values.yaml@@ spec.ports @@
# v1/Service/ess-ci/release-name-matrix-rtc-sfu
! + one list entry added:
+ - name: metrics
+ port: 6789
+ targetPort: metrics
@@ servicemonitor-release-name-matrix-rtc-authorisation-service.yaml @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-authorisation-service
! - one file removed
- apiVersion: monitoring.coreos.com/v1
- kind: ServiceMonitor
- metadata:
- labels:
- helm.sh/chart: "matrix-stack-25.6.3-dev"
- app.kubernetes.io/managed-by: Helm
- app.kubernetes.io/part-of: matrix-stack
- app.kubernetes.io/component: matrix-rtc-authorisation-service
- app.kubernetes.io/name: matrix-rtc-authorisation-service
- app.kubernetes.io/instance: release-name-matrix-rtc-authorisation-service
- app.kubernetes.io/version: "0.2.3"
- name: release-name-matrix-rtc-authorisation-service
- namespace: ess-ci
@@ spec.endpoints.0.port @@
# monitoring.coreos.com/v1/ServiceMonitor/ess-ci/release-name-matrix-rtc-sfu
! ± value change
- http
+ metrics
|
gaelgatelement
force-pushed
the
gaelg/matrix-rtc-metrics
branch
2 times, most recently
from
66ca7d4 to
4dd40dc
Compare
benbz
approved these changes
Jun 23, 2025
Member
benbz
left a comment
benbz
left a comment
There was a problem hiding this comment.
This all looks plausible but there's no automated way of knowing whether this is correct.
How tricky would it be to have an integration test that looks at all ServiceMonitors, looks at all matching Services, poke /metrics on all Endpoints on said Services and assert all have successful responses with Prometheus/OpenTelemetry looking responses
Member
Author
The difficult part is that we have to do some |
Member
Makes sense. Or |
benbz
reviewed
Jun 30, 2025
gaelgatelement
force-pushed
the
gaelg/matrix-rtc-metrics
branch
3 times, most recently
from
104869b to
c9aff39
Compare
gaelgatelement
force-pushed
the
gaelg/matrix-rtc-metrics
branch
2 times, most recently
from
b69c358 to
84b1088
Compare
gaelgatelement
force-pushed
the
gaelg/matrix-rtc-metrics
branch
from
84b1088 to
4694f5d
Compare
benbz
reviewed
Jun 30, 2025
gaelgatelement
force-pushed
the
gaelg/matrix-rtc-metrics
branch
from
c93b5c0 to
4ab25b2
Compare
benbz
approved these changes
Jun 30, 2025
gaelgatelement
force-pushed
the
gaelg/matrix-rtc-metrics
branch
from
c0f9a9f to
ca62c63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the room, it was raised that matrix-rtc services monitors were wrong : https://matrix.to/#/!RkXKfjpGXIVObpCqOI:element.io/$DM2GN8exEvvq69WPVVVBMJf-1G_E0_35G7pSB0nkhCw?via=matrix.org&via=element.io&via=k8ekat.dev