Merged
Conversation
benbz
force-pushed
the
bbz/ci-fixes-after-pull-request-switch
branch
from
dcd2c5d to
6c4915d
Compare
benbz
force-pushed
the
bbz/ci-fixes-after-pull-request-switch
branch
from
6c4915d to
745a5c8
Compare
benbz
force-pushed
the
bbz/ci-fixes-after-pull-request-switch
branch
2 times, most recently
from
07c0a6f to
4217acc
Compare
| @@ -0,0 +1 @@ | |||
| Don't push chart OCI images for every PR, only tags and main. | |||
Member
There was a problem hiding this comment.
Suggested change
| Don't push chart OCI images for every PR, only tags and main. | |
| Don't push chart OCI images for every PR, only tags, main, and manual workflows triggers. |
Member
Author
There was a problem hiding this comment.
Do you have objections to me going the other way and doing the below?
Suggested change
| Don't push chart OCI images for every PR, only tags and main. | |
| Don't push chart OCI images for every PR. |
gaelgatelement
approved these changes
Jul 1, 2025
benbz
force-pushed
the
bbz/ci-fixes-after-pull-request-switch
branch
from
4217acc to
4c4eae2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes up from #586 as discovered with #588.
The changes to
dyffjobs can't be tested as the newworkflow_runworkflow doesn't exist on the default branch yet. I think once it exists I'll be able to modify it in PRs, so might need to merge and iterate quickly