Skip to content

service/pods labels matching tests: also skip succeeded #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaelgatelement merged 3 commits into from
Jul 2, 2025
Merged

service/pods labels matching tests: also skip succeeded #598

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f602d0
service/pods labels matching tests: also skip succeeded
gaelgatelement Jul 2, 2025
25526f1
Update newsfragments/598.internal.md
gaelgatelement Jul 2, 2025
4d5345b
Enhance assert words
gaelgatelement Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions newsfragments/598.internal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Tests : Dont check services matching labels against terminating pods.
Comment thread
gaelgatelement marked this conversation as resolved.
Outdated
5 changes: 3 additions & 2 deletions tests/integration/test_networking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ async def test_services_have_matching_labels(
label_selectors = {label: value for label, value in service.spec.selector.items()}

async for pod in kube_client.list(Pod, namespace=generated_data.ess_namespace, labels=label_selectors):
if pod.status and pod.status.phase == "Terminating":
if pod.status and pod.status.phase not in ("Terminating", "Succeeded"):
continue # Skip terminating pods
assert service.metadata, f"Encountered a service without metadata : {service}"
assert pod.metadata, f"Encountered a pod without metadata : {pod}"
Expand All @@ -58,7 +58,8 @@ async def test_services_have_matching_labels(
assert value.startswith(
pod.metadata.labels[label.replace("k8s.element.io/target-", "app.kubernetes.io/")]
), (
f"{pod.metadata.name} does not have the correct label {label}={value} "
f"{value} does not starts with "
f"{pod.metadata.labels[label.replace('k8s.element.io/target-', 'app.kubernetes.io/')]}"
Comment thread
gaelgatelement marked this conversation as resolved.
Outdated
f"(pod status phase : {pod.status.phase if pod.status else 'N/A'}"
)

Expand Down
Loading
⚡