CI: change the comparision branch for the dyff job after the change to the source branch.#602
Merged
CI: change the comparision branch for the dyff job after the change to the source branch.#602
Conversation
…o the source branch.
dyff of changes in rendered templates of CI manifestsNo changes in rendered templates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#586 removed
with.ref: ${{ github.event.pull_request.head.sha }}fromactions/checkout. This had the impact of switching from checking out the HEAD of the PR to checking out a merge between the HEAD of the PR and the target branch. If there were changes on the target branch since the PR forked they would then show up in thedyff. Update the base branch to the current state of the target branch (by name rather than by SHA due to https://github.com/orgs/community/discussions/59677).I have deliberately created this PR on a commit prior to the merge of #578 to see whether anything shows up or not