Skip to content

Fix flaking tests #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaelgatelement merged 2 commits into from
Jul 25, 2025
Merged

Fix flaking tests #627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbf01bc
fix flaking upgrade test
gaelgatelement Jul 25, 2025
2d119d7
upgrade: fix flaky tests
gaelgatelement Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions newsfragments/627.internal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix flaking tests when checking upgrades.
2 changes: 1 addition & 1 deletion tests/integration/test_networking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ async def test_services_have_matching_labels(
label_selectors = {label: value for label, value in service.spec.selector.items()}

async for pod in kube_client.list(Pod, namespace=generated_data.ess_namespace, labels=label_selectors):
if pod.status and pod.status.phase not in ("Terminating", "Succeeded"):
if pod.status and pod.status.phase in ("Terminating", "Succeeded"):
continue # Skip terminating pods
assert service.metadata, f"Encountered a service without metadata : {service}"
assert pod.metadata, f"Encountered a pod without metadata : {pod}"
Expand Down
Loading
⚡