Skip to content

fix flakes in test_pods_monitored #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaelgatelement wants to merge 1 commit into from
Closed

fix flakes in test_pods_monitored #628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions newsfragments/628.internal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix flakes in CI tests when checking monitored pods.
2 changes: 2 additions & 0 deletions tests/integration/test_networking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,8 @@ async def test_pods_monitored(
):
if pod.metadata and pod.metadata.annotations and "has-no-service-monitor" in pod.metadata.annotations:
continue
if pod.status and pod.status.phase in ("Terminating", "Succeeded"):
continue # Skip terminating pods
elif pod.metadata:
assert pod.metadata.name, "Encountered a pod without a name"
all_monitorable_pods.add(pod.metadata.name)
Expand Down
Loading
⚡