Skip to content

Synapse: fix requests being routed to initial-synchrotron incorrectly #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benbz merged 5 commits into from
Jul 29, 2025
Merged

Synapse: fix requests being routed to initial-synchrotron incorrectly #632

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bcbfb7f
Synapse: fix requests being routed to initial-synchrotron incorrectly
benbz Jul 29, 2025
322cc22
Test that HAProxy routes correctly to Synapse workers
benbz Jul 29, 2025
57e23c9
Don't retry ClientResponseError, we end up retrying all 4xx/5xx statu…
benbz Jul 29, 2025
80fea4e
CI: correctly setup the environment to retry 429s on upgrade
benbz Jul 29, 2025
1bef171
CI: make uploaded log artifacts distinct
benbz Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions charts/matrix-stack/configs/synapse/partial-haproxy.cfg.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,18 +74,18 @@ frontend synapse-http-in
http-request set-var(req.backend) path,map_reg(/synapse/path_map_file,main) unless { var(req.backend) -m found }
{{- if dig "initial-synchrotron" "enabled" false .workers }}

acl is_initial_sync path -m reg ^/_matrix/client/(api/v1|r0|v3)/initialSync$
acl is_initial_sync path -m reg ^/_matrix/client/(api/v1|r0|v3)/rooms/[^/]+/initialSync$
# https://spec.matrix.org/v1.14/client-server-api/#get_matrixclientv3sync
acl is_initial_sync path -m reg ^/_matrix/client/(r0|v3)/sync$ { urlp("full_state") -m str true }
acl is_initial_sync path -m reg ^/_matrix/client/(r0|v3)/sync$ !{ urlp("since") -m found }
# https://spec.matrix.org/latest/client-server-api/#get_matrixclientv3events
acl is_initial_sync path -m reg ^/_matrix/client/(api/v1|r0|v3)/events$ !{ urlp("from") -m found }
acl has_available_initial_syncs nbsrv('synapse-initial-synchrotron') ge 1

# Set to the initial-synchrotron backend if it is one of these magic paths AND we have workers in the initial-synchrotron backend
# This means that we don't update the backend from synchrotron if that's configured but there's no initial-synchrotron servers available
# And then can it fallback to main if there are no synchrotron servers either
http-request set-var(req.backend) str('initial-synchrotron') if is_initial_sync { nbsrv('synapse-initial-synchrotron') ge 1 }
http-request set-var(req.backend) str('initial-synchrotron') if has_available_initial_syncs { path -m reg ^/_matrix/client/(api/v1|r0|v3)/initialSync$ }
http-request set-var(req.backend) str('initial-synchrotron') if has_available_initial_syncs { path -m reg ^/_matrix/client/(api/v1|r0|v3)/rooms/[^/]+/initialSync$ }
# https://spec.matrix.org/v1.14/client-server-api/#get_matrixclientv3sync
http-request set-var(req.backend) str('initial-synchrotron') if has_available_initial_syncs { path -m reg ^/_matrix/client/(r0|v3)/sync$ } { urlp("full_state") -m str true }
http-request set-var(req.backend) str('initial-synchrotron') if has_available_initial_syncs { path -m reg ^/_matrix/client/(r0|v3)/sync$ } !{ urlp("since") -m found }
# https://spec.matrix.org/latest/client-server-api/#get_matrixclientv3events
http-request set-var(req.backend) str('initial-synchrotron') if has_available_initial_syncs { path -m reg ^/_matrix/client/(api/v1|r0|v3)/events$ } !{ urlp("from") -m found }
{{- end }}

{{- if include "element-io.matrix-authentication-service.readyToHandleAuth" (dict "root" $root) }}
Expand Down
1 change: 1 addition & 0 deletions newsfragments/632.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Synapse: fix requests being routed to initial-synchrotron incorrectly.
Loading
⚡