Skip to content

Commit 8876aa8

Browse files
committed
Fill in synapse/storage/controllers/persist_events.py
1 parent 84cf43f commit 8876aa8

1 file changed

Lines changed: 9 additions & 2 deletions

File tree

synapse/storage/controllers/persist_events.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@
6161
start_active_span_follows_from,
6262
trace,
6363
)
64+
from synapse.metrics import SERVER_NAME_LABEL
6465
from synapse.metrics.background_process_metrics import run_as_background_process
6566
from synapse.storage.controllers.state import StateStorageController
6667
from synapse.storage.databases import Databases
@@ -101,6 +102,7 @@
101102
forward_extremities_counter = Histogram(
102103
"synapse_storage_events_forward_extremities_persisted",
103104
"Number of forward extremities for each new event",
105+
labelnames=[SERVER_NAME_LABEL],
104106
buckets=(1, 2, 3, 5, 7, 10, 15, 20, 50, 100, 200, 500, "+Inf"),
105107
)
106108

@@ -109,6 +111,7 @@
109111
stale_forward_extremities_counter = Histogram(
110112
"synapse_storage_events_stale_forward_extremities_persisted",
111113
"Number of unchanged forward extremities for each new event",
114+
labelnames=[SERVER_NAME_LABEL],
112115
buckets=(0, 1, 2, 3, 5, 7, 10, 15, 20, 50, 100, 200, 500, "+Inf"),
113116
)
114117

@@ -835,9 +838,13 @@ async def _calculate_new_extremities(
835838
# We only update metrics for events that change forward extremities
836839
# (e.g. we ignore backfill/outliers/etc)
837840
if result != latest_event_ids:
838-
forward_extremities_counter.observe(len(result))
841+
forward_extremities_counter.labels(
842+
**{SERVER_NAME_LABEL: self.server_name}
843+
).observe(len(result))
839844
stale = latest_event_ids & result
840-
stale_forward_extremities_counter.observe(len(stale))
845+
stale_forward_extremities_counter.labels(
846+
**{SERVER_NAME_LABEL: self.server_name}
847+
).observe(len(stale))
841848

842849
return result
843850

0 commit comments

Comments
 (0)