Skip to content

MSC4108: Add a Content-Type header on the PUT response #17253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandhose merged 3 commits into from
Nov 26, 2024
+8 −0
Merged

MSC4108: Add a Content-Type header on the PUT response #17253

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3eb9cc0
MSC4108: Add a Content-Type header on the PUT response
sandhose May 31, 2024
e8ce1ec
Mention Cloudflare in the comment
anoadragon453 Jun 3, 2024
3b199d0
Newsfile
sandhose Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions rust/src/rendezvous/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,12 @@ impl RendezvousHandler {
let mut response = Response::new(Bytes::new());
*response.status_mut() = StatusCode::ACCEPTED;
prepare_headers(response.headers_mut(), session);

// Even though this isn't mandated by the MSC, we set a Content-Type on the response. It
// doesn't do any harm as the body is empty, but this helps escape a bug in some reverse
// proxy/cache setup which strips the ETag header if there is no Content-Type set.
Comment thread
anoadragon453 marked this conversation as resolved.
response.headers_mut().typed_insert(ContentType::text());

http_response_to_twisted(twisted_request, response)?;

Ok(())
Expand Down
⚡