Never autojoin deactivated & suspended users.#18073
Merged
devonh merged 9 commits intoelement-hq:developfrom Jan 28, 2025
Merged
Never autojoin deactivated & suspended users.#18073devonh merged 9 commits intoelement-hq:developfrom
devonh merged 9 commits intoelement-hq:developfrom
Conversation
Half-Shot
changed the title
turt2live
reviewed
Jan 23, 2025
anoadragon453
changed the title
devonh
approved these changes
Jan 27, 2025
Member
devonh
left a comment
devonh
left a comment
There was a problem hiding this comment.
The conversion of the existing logic looks good to me.
Also, the new logic makes sense.
One small issue with an errant comment in the tests, otherwise everything looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the logic so that deactivated users are always ignored. Suspended users were already effectively ignored as Synapse forbids a join while suspended.