Document missing server config options#18122
Merged
MadLittleMods merged 6 commits intodevelopfrom Feb 12, 2025
Merged
Conversation
MadLittleMods
commented
Jan 31, 2025
MadLittleMods
commented
Jan 31, 2025
This reverts commit 5495be2.
erikjohnston
approved these changes
Feb 12, 2025
Contributor
Author
|
Thanks for the review @erikjohnston 🦡 |
3 tasks
MadLittleMods
added a commit
that referenced
this pull request
Apr 24, 2026
…19711) Known problems: #18117 As a follow-up, we should consider removing this config option altogether. It's "expensive" and claims to "prevent bugs" but actually introduces a whole new class of bugs. It could be re-introduced with a more holistic solution to the typing. Or a completely new approach (safe mode that blows up when someone mutates the event content, always make deep clones when handing out references, etc) The `use_frozen_dict` config option was there [since inception](a7b65bd) but was only recently [documented](#18122) for completeness sake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking into the
USE_FROZEN_DICTSoption during the review of #18103 (comment) and noticed that there are several other server config options that aren't in the docs.Dev notes
synapse/synapse/config/server.py
Lines 421 to 424 in a9361c4
synapse/synapse/config/server.py
Line 774 in a9361c4
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.(run the linters)