Skip to content

Add log message when worker lock timeouts get large#18124

Merged
devonh merged 2 commits intodevelopfrom
devon/lock-logging
Feb 12, 2025
Merged

Add log message when worker lock timeouts get large#18124
devonh merged 2 commits intodevelopfrom
devon/lock-logging

Conversation

@devonh
Copy link
Copy Markdown
Member

@devonh devonh commented Jan 31, 2025

This is to help track down a possible, but very rare, worker deadlock that was seen on matrix.org.
In theory, you could work back from an instance of these new logs to the approximate time when the lock was obtained and focus the diagnostic efforts there.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@devonh devonh requested a review from a team as a code owner January 31, 2025 23:44
@devonh devonh merged commit 74aa478 into develop Feb 12, 2025
@devonh devonh deleted the devon/lock-logging branch February 12, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants