Skip to content

Fix registering of background updates for split main/state db#18509

Merged
erikjohnston merged 2 commits intoelement-hq:developfrom
clokep:fix-state-migration
Jun 25, 2025
Merged

Fix registering of background updates for split main/state db#18509
erikjohnston merged 2 commits intoelement-hq:developfrom
clokep:fix-state-migration

Conversation

@clokep
Copy link
Copy Markdown
Contributor

@clokep clokep commented Jun 3, 2025

The background updates are being registered on an object that is for the state database, but the actual tables are on the main database. This just moves them to a different store that can access the right stuff.

I noticed this when trying to do a full schema dump cause I was curious what has changed since the last one.

Fixes #16054

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 3, 2025

CLA assistant check
All committers have signed the CLA.

@clokep clokep force-pushed the fix-state-migration branch from 4fe2ff9 to 38b8820 Compare June 3, 2025 15:26
@clokep clokep marked this pull request as ready for review June 3, 2025 15:55
@clokep clokep requested a review from a team as a code owner June 3, 2025 15:55
Copy link
Copy Markdown
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops!

@erikjohnston erikjohnston merged commit 0c7d991 into element-hq:develop Jun 25, 2025
39 checks passed
@clokep clokep deleted the fix-state-migration branch September 30, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KeyError on recent background updates

4 participants