Skip to content

Document that some config options for the user directory are in violation of the Matrix spec#18548

Merged
MadLittleMods merged 7 commits intoelement-hq:developfrom
Johennes:johannes/user-directory-config-spec-compliance
Jul 15, 2025
Merged

Document that some config options for the user directory are in violation of the Matrix spec#18548
MadLittleMods merged 7 commits intoelement-hq:developfrom
Johennes:johannes/user-directory-config-spec-compliance

Conversation

@Johennes
Copy link
Copy Markdown
Contributor

@Johennes Johennes commented Jun 13, 2025 •
edited
Loading

Fixes: #17534

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@github-actions github-actions Bot deployed to PR Documentation Preview June 13, 2025 09:31 Active
@github-actions github-actions Bot deployed to PR Documentation Preview June 13, 2025 09:32 Active
@Johennes Johennes force-pushed the johannes/user-directory-config-spec-compliance branch from e2ef8c1 to 5df3d39 Compare June 13, 2025 09:43
@github-actions github-actions Bot deployed to PR Documentation Preview June 13, 2025 09:44 Active
@Johennes
Document that some config options for the user directory are in viola…
2a170f5 
…tion of the Matrix spec

Fixes: element-hq#17534
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
@Johennes Johennes force-pushed the johannes/user-directory-config-spec-compliance branch from 5df3d39 to 2a170f5 Compare June 13, 2025 09:47
@Johennes Johennes mentioned this pull request Jun 13, 2025
Closed
@github-actions github-actions Bot deployed to PR Documentation Preview June 13, 2025 09:49 Active
@Johennes Johennes marked this pull request as ready for review June 13, 2025 09:50
@Johennes Johennes requested a review from a team as a code owner June 13, 2025 09:50
MadLittleMods
MadLittleMods reviewed Jul 11, 2025
View reviewed changes
Comment thread schema/synapse-config.schema.yaml Outdated
Comment thread schema/synapse-config.schema.yaml Outdated
Comment thread schema/synapse-config.schema.yaml Outdated
@Johennes @MadLittleMods
Improve wording
f63b896 
Co-authored-by: Eric Eastwood <madlittlemods@gmail.com>
@github-actions github-actions Bot deployed to PR Documentation Preview July 14, 2025 06:30 Active
@github-actions github-actions Bot deployed to PR Documentation Preview July 14, 2025 06:32 Active
@Johennes
Move disclaimer to enabled property
aa8ca77 
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
@github-actions github-actions Bot deployed to PR Documentation Preview July 14, 2025 06:37 Active
@github-actions github-actions Bot deployed to PR Documentation Preview July 14, 2025 06:43 Active
@Johennes Johennes requested a review from MadLittleMods July 14, 2025 07:47
MadLittleMods
MadLittleMods reviewed Jul 14, 2025
View reviewed changes
Comment thread docs/usage/configuration/config_documentation.md Outdated
@Johennes
Add missing blank line
1a2a5db 
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
@github-actions github-actions Bot deployed to PR Documentation Preview July 15, 2025 06:23 Active
@Johennes Johennes requested a review from MadLittleMods July 15, 2025 06:42
@MadLittleMods MadLittleMods merged commit b274d65 into element-hq:develop Jul 15, 2025
35 checks passed
@MadLittleMods
Copy link
Copy Markdown
Contributor

MadLittleMods commented Jul 15, 2025

Thanks for clarifying the docs @Johennes 🐫

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MadLittleMods MadLittleMods MadLittleMods approved these changes

Assignees

No one assigned

Labels

A-Config A-Docs A-Search A-User-Directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

user_directory_search_enabled is not spec compliant

2 participants

@Johennes @MadLittleMods
⚡