Speed up device deletion#18602
Merged
erikjohnston merged 10 commits intodevelopfrom Jun 30, 2025
Merged
Conversation
erikjohnston
force-pushed
the
erikj/better_device_deletion
branch
from
329749e to
e998de4
Compare
sandhose
approved these changes
Jun 27, 2025
Member
sandhose
left a comment
sandhose
left a comment
There was a problem hiding this comment.
Thanks for making it easily reviewable commit by commit, LGTM
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
anoadragon453
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to handle the case of deleting lots of "bot" devices at once.
Reviewable commit-by-commit