Skip to content

Remove some obsolete Twisted version checks.#18729

Merged
reivilibre merged 3 commits intodevelopfrom
rei/twisted_2120_vchecks
Jul 30, 2025
Merged

Remove some obsolete Twisted version checks.#18729
reivilibre merged 3 commits intodevelopfrom
rei/twisted_2120_vchecks

Conversation

@reivilibre
Copy link
Copy Markdown
Contributor

Follows: #18727

  1. Remove obsolete Twisted version checks

Signed-off-by: Olivier 'reivilibre <oliverw@matrix.org>
@reivilibre reivilibre marked this pull request as ready for review July 24, 2025 16:34
@reivilibre reivilibre requested a review from a team as a code owner July 24, 2025 16:34
Comment thread changelog.d/18729.misc
@@ -0,0 +1 @@
Bump minimum version bound on Twisted to 21.2.0. No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why same changelog as #18727 ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because it's part and parcel of the same work (towncrier will amalgamate these into the same changelog entry)

As a user I don't think I'd particularly care about seeing this PR individually in the changelog, combining it with the Twisted bump is fine

@reivilibre reivilibre merged commit 16a639e into develop Jul 30, 2025
44 checks passed
@reivilibre reivilibre deleted the rei/twisted_2120_vchecks branch July 30, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants