Implement the push rules for experimental MSC4306: Thread Subscriptions.#18762
Merged
reivilibre merged 10 commits intodevelopfrom Aug 6, 2025
Merged
Implement the push rules for experimental MSC4306: Thread Subscriptions.#18762reivilibre merged 10 commits intodevelopfrom
reivilibre merged 10 commits intodevelopfrom
Conversation
reivilibre
changed the title
Contributor
MadLittleMods
left a comment
MadLittleMods
left a comment
There was a problem hiding this comment.
I don't know what I'm looking at when at when it comes to push rules
anoadragon453
approved these changes
Aug 5, 2025
Member
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
No hard blockers from me, but it would be good to fix/add comments for the rest of the threads on this PR.
| # specify this in the `bdist_wheel` config below. | ||
| py_limited_api=True, | ||
| # We always build in release mode, as we can't distinguish | ||
| # We always build in release mode, as we can't distinguish |
Member
There was a problem hiding this comment.
FYI this has already been fixed in 25289b6.
But no harm in including it in this PR.
anoadragon453
approved these changes
Aug 5, 2025
reivilibre
force-pushed
the
rei/t2_msc4306_conflict
branch
from
aed6d75 to
29c1ae4
Compare
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
reivilibre
force-pushed
the
rei/t2_pushrules
branch
from
36a380a to
08725b5
Compare
reivilibre
force-pushed
the
rei/t2_pushrules
branch
from
91eb150 to
618ef20
Compare
Contributor
Author
|
CI failures are not related to this PR (ongoing issue on develop) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows: #18756
Implements: MSC4306
Base:
rei/t2_msc4306_conflictThis pull request is commit-by-commit review friendly.
Add MSC4306's default push rules
Add batch
get_subscribers_to_threadOptimise push rule evaluation by getting subscribers in batch