Skip to content

Trace how much work is being done while "recursively fetching redactions"#18854

Merged
MadLittleMods merged 3 commits intodevelopfrom
madlittlemods/trace-recursively-fetching-redactions
Aug 27, 2025
Merged

Trace how much work is being done while "recursively fetching redactions"#18854
MadLittleMods merged 3 commits intodevelopfrom
madlittlemods/trace-recursively-fetching-redactions

Conversation

@MadLittleMods
Copy link
Copy Markdown
Contributor

@MadLittleMods MadLittleMods commented Aug 21, 2025

Trace how much work is being done while "recursively fetching redactions"

Spawning from observing this trace for a /messages request (RoomMessageListRestServlet). We don't know if it took a while for the database to fetch a single redaction or a whole chain of redactions.

Trace before this PR without any detail on what happened while 'recursively fetching redactions'

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@MadLittleMods MadLittleMods marked this pull request as ready for review August 21, 2025 17:56
@MadLittleMods MadLittleMods requested a review from a team as a code owner August 21, 2025 17:56
@MadLittleMods MadLittleMods merged commit 68068de into develop Aug 27, 2025
44 checks passed
@MadLittleMods MadLittleMods deleted the madlittlemods/trace-recursively-fetching-redactions branch August 27, 2025 17:27
@MadLittleMods
Copy link
Copy Markdown
Contributor Author

Thanks for the review @anoadragon453 🐜

@MadLittleMods MadLittleMods added the A-Tracing OpenTracing (maybe OpenTelemetry in the future) label Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Messages-Endpoint A-Tracing OpenTracing (maybe OpenTelemetry in the future)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants