Reduce strictness of delayed event delta fetching#18858
Merged
anoadragon453 merged 2 commits intoelement-hq:developfrom Aug 27, 2025
Merged
Reduce strictness of delayed event delta fetching#18858anoadragon453 merged 2 commits intoelement-hq:developfrom
anoadragon453 merged 2 commits intoelement-hq:developfrom
Conversation
- Use `allow_none=True` on the event lookup - Don't check the room ID of events Do this to not fail on deltas for rejected events, and to be more in line with how other delta event lookups are done.
1426eab to
3107cde
Compare
anoadragon453
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow_none=Trueon the event lookupDo this to not fail on deltas for rejected events, and to be more in line with how other delta event lookups are done.
MSC4140
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.