Skip to content

Reduce strictness of delayed event delta fetching#18858

Merged
anoadragon453 merged 2 commits intoelement-hq:developfrom
AndrewFerr:delayed-event-delta-lax-lookup
Aug 27, 2025
Merged

Reduce strictness of delayed event delta fetching#18858
anoadragon453 merged 2 commits intoelement-hq:developfrom
AndrewFerr:delayed-event-delta-lax-lookup

Conversation

@AndrewFerr
Copy link
Copy Markdown
Member

@AndrewFerr AndrewFerr commented Aug 22, 2025

  • Use allow_none=True on the event lookup
  • Don't check the room ID of events

Do this to not fail on deltas for rejected events, and to be more in line with how other delta event lookups are done.

MSC4140

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@AndrewFerr AndrewFerr requested a review from a team as a code owner August 22, 2025 17:26
- Use `allow_none=True` on the event lookup
- Don't check the room ID of events

Do this to not fail on deltas for rejected events, and to be more in
line with how other delta event lookups are done.
@AndrewFerr AndrewFerr force-pushed the delayed-event-delta-lax-lookup branch from 1426eab to 3107cde Compare August 22, 2025 17:28
@anoadragon453 anoadragon453 merged commit c339021 into element-hq:develop Aug 27, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants