Skip to content

Revert "Switch to OpenTracing's ContextVarsScopeManager (#18849)" #19007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MadLittleMods merged 13 commits into from
Oct 2, 2025
Merged

Revert "Switch to OpenTracing's ContextVarsScopeManager (#18849)" #19007

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0717cba
Revert "Switch to OpenTracing's `ContextVarsScopeManager` (#18849)"
MadLittleMods Oct 1, 2025
eb359e9
Add changelog
MadLittleMods Oct 1, 2025
34c4814
Fix lints
MadLittleMods Oct 1, 2025
500a187
Fix logcontext problems in `test_run_in_background_active_scope_still…
MadLittleMods Oct 1, 2025
9c4ea3c
Revert "Fix logcontext problems in `test_run_in_background_active_sco…
MadLittleMods Oct 1, 2025
76af9cf
Link background process to request trace
MadLittleMods Oct 2, 2025
38e121d
Add tests to ensure `run_as_background_process` has tracing
MadLittleMods Oct 2, 2025
6ac4454
Friendly span names in assertion messages
MadLittleMods Oct 2, 2025
094c01d
Fix lints
MadLittleMods Oct 2, 2025
5cc63af
Use previous pattern
MadLittleMods Oct 2, 2025
db2835e
Fix lints
MadLittleMods Oct 2, 2025
7b31c56
Fix missing word typo
MadLittleMods Oct 2, 2025
648a24f
Remove duplicate word typo
MadLittleMods Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/19007.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Switch back to own custom `LogContextScopeManager` instead of OpenTracing's `ContextVarsScopeManager` which was causing problems when using the experimental `SYNAPSE_ASYNC_IO_REACTOR` option with tracing enabled.
Comment thread
MadLittleMods marked this conversation as resolved.
Outdated
Loading
⚡