Prevent duplicate logging setup when running multiple Synapse instances#19067
Merged
MadLittleMods merged 4 commits intodevelopfrom Oct 30, 2025
Merged
Prevent duplicate logging setup when running multiple Synapse instances#19067MadLittleMods merged 4 commits intodevelopfrom
MadLittleMods merged 4 commits intodevelopfrom
Conversation
e233fc4 to
6397095
Compare
Fix `logBeginner` missing Clarify once for the Python process
6397095 to
24d14f1
Compare
Conflicts: synapse/config/logger.py
reivilibre
approved these changes
Oct 30, 2025
Contributor
Author
|
Thanks for the review @reivilibre 🦪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be mindful that it's possible to run Synapse multiple times in the same Python process. So we only need to do some part of the logging setup once.
Background
As part of Element's plan to support a light form of vhosting (virtual host) (multiple instances of Synapse in the same Python process), we're currently diving into the details and implications of running multiple instances of Synapse in the same Python process.
"Per-tenant logging" tracked internally by https://github.com/element-hq/synapse-small-hosts/issues/48
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.