Fix lost logcontext on HomeServer.shutdown()#19108
Merged
MadLittleMods merged 9 commits intodevelopfrom Nov 3, 2025
Merged
Conversation
MadLittleMods
commented
Oct 28, 2025
Comment on lines
+511
to
+512
| with PreserveLoggingContext(): | ||
| background_process.cancel() |
Contributor
Author
There was a problem hiding this comment.
This is the main fix!
See the Deferred callbacks section of our logcontext docs for more info (specifically using solution 2).
Heads-up, I wrote the docs too so it's my assumptions/understanding all the way down. Apply your own scrutiny.
MadLittleMods
commented
Oct 28, 2025
anoadragon453
approved these changes
Nov 3, 2025
Member
anoadragon453
left a comment
There was a problem hiding this comment.
Thanks for jumping on this!
Contributor
Author
|
Thanks for the review @anoadragon453 🦓 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix lost logcontext on
HomeServer.shutdown()Same fix as #19090
Spawning from working on clean tenant deprovisioning in the Synapse Pro for small hosts project (https://github.com/element-hq/synapse-small-hosts/pull/204).
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.