Conversation
sandhose
approved these changes
Nov 18, 2025
Member
sandhose
left a comment
There was a problem hiding this comment.
Good overall, but maybe we should just roll back to the old way we did that instead?
Member
There was a problem hiding this comment.
I wonder if we wouldn't be better off just doing what we were doing before? e.g.
@property
def _metadata_url(self) -> str:
return f"{str(self._config.endpoint).rstrip('/')}/.well-known/openid-configuration"
@property
def _introspection_endpoint(self) -> str:
return f"{str(self._config.endpoint).rstrip('/')}/oauth2/introspect"alternatively we could probably use urllib.parse.urljoin, but that might also have weird consequences depending on the trailing slash:
>>> import urllib.parse
>>> urllib.parse.urljoin("https://example.com", ".well-known/openid-configuration")
'https://example.com/.well-known/openid-configuration'
>>> urllib.parse.urljoin("https://example.com/foo", ".well-known/openid-configuration")
'https://example.com/.well-known/openid-configuration'
>>> urllib.parse.urljoin("https://example.com/foo/", ".well-known/openid-configuration")
'https://example.com/foo/.well-known/openid-configuration'
Member
Author
There was a problem hiding this comment.
Hmm yeah the old way seems a lot simpler.
Not sure why it was drastically changed in the first place.
I say we go back to the old way.
devonh
added a commit
that referenced
this pull request
Nov 18, 2025
Fixes #19184 ### Pull Request Checklist <!-- Please read https://element-hq.github.io/synapse/latest/development/contributing_guide.html before submitting your pull request --> * [X] Pull request is based on the develop branch * [X] Pull request includes a [changelog file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog). The entry should: - Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from `EventStore` to `EventWorkerStore`.". - Use markdown where necessary, mostly for `code blocks`. - End with either a period (.) or an exclamation mark (!). - Start with a capital letter. - Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry. * [X] [Code style](https://element-hq.github.io/synapse/latest/code_style.html) is correct (run the [linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters))
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Nov 18, 2025
Fixes a bug introduced in v1.142.0 preventing subpaths in MAS endpoints from working. Link: element-hq/synapse#19184 Link: element-hq/synapse#19186 Signed-off-by: Petr Vaněk <arkamar@gentoo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19184
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.