Translations are dissapearing in umbrella

[amatalai]

When you run mix gettext.extract from umbrella root not every module is forced to recompile, which causes translations to disappear.

Example repo: https://github.com/amatalai/gettext_umbrella_issue

Probably somehow related to #165

[amatalai]

My current workaround: https://gist.github.com/amatalai/1877f48a195f578682cfd20e66c6544e

[josevalim]

Thanks @amatalai!

Indeed gettext does not work across dependencies. One possibly solution to this problem is for us to add an option that specifies exactly which apps to run to extract the dependencies from. Although your work around is also fine for now (albeit slightly inefficient).

[maennchen]

@josevalim I'm having the same issue as well. Was there anything done in the meantime that should solve the issue?

[josevalim]

@amatalai's workaround seems to be the way to go for now.

[maennchen]

@josevalim Could the workaround be incorporated into the extract mix task directly?

(Via Arg / Config / somehow detect the umbrella)

[maennchen]

(As always I'd be happy to provide a PR 😃 if that is welcome)

[josevalim]

I think the work around can be more efficient but I didn't have time to look at it yet, unfortunately.

[maennchen]

Using the workaround produces a few issues:

• All translations are marked with the flag elixir-format
• No longer used translations are not discarded
• I get the following warning multiple times when extracting:

Compiling lib/hygeia_gettext.ex (it's taking more than 10s)
warning: the Gettext backend HygeiaGettext has the same :priv directory as HygeiaGettext, which means they will override each other. Please set the :priv option to different directories or use Gettext inside each backend
  (elixir 1.12.1) lib/enum.ex:2356: Enum."-reduce/3-lists^foldl/2-0-"/3
  (gettext 0.18.2) lib/gettext/extractor.ex:80: Gettext.Extractor.pot_files/2
  (gettext 0.18.2) lib/mix/tasks/gettext.extract.ex:55: Mix.Tasks.Gettext.Extract.extract/2
  (gettext 0.18.2) lib/mix/tasks/gettext.extract.ex:37: Mix.Tasks.Gettext.Extract.run/1
  (mix 1.12.1) lib/mix/task.ex:394: anonymous fn/3 in Mix.Task.run_task/3
  (mix 1.12.1) lib/mix/project.ex:353: Mix.Project.in_project/4
  (elixir 1.12.1) lib/file.ex:1560: File.cd!/2
  (mix 1.12.1) lib/mix/task.ex:520: anonymous fn/4 in Mix.Task.recur/1
  (elixir 1.12.1) lib/enum.ex:2356: Enum."-reduce/3-lists^foldl/2-0-"/3
  (mix 1.12.1) lib/mix/task.ex:519: Mix.Task.recur/1
  (mix 1.12.1) lib/mix/project_stack.ex:181: Mix.ProjectStack.recur/1
  (mix 1.12.1) lib/mix/task.ex:394: anonymous fn/3 in Mix.Task.run_task/3
  (mix 1.12.1) lib/mix/cli.ex:84: Mix.CLI.run_task/2
  (elixir 1.12.1) src/elixir_compiler.erl:75: :elixir_compiler.dispatch/4
  (elixir 1.12.1) src/elixir_compiler.erl:60: :elixir_compiler.compile/3
  (elixir 1.12.1) src/elixir_lexical.erl:15: :elixir_lexical.run/3
  (elixir 1.12.1) src/elixir_compiler.erl:18: :elixir_compiler.quoted/3
  (elixir 1.12.1) lib/code.ex:1261: Code.require_file/2

All of this can be reproduced when using mix gettext.extract.umbrella in https://github.com/jshmrtn/hygeia

[josevalim]

Hi @maennchen, I will take some time this week to look at this. Can you please make sure those problems happen in the initial repo: https://github.com/amatalai/gettext_umbrella_issue - feel free to fork it. Looking at a minimal app is going to make it a bit easier for me to address it. :)

[maennchen]

@josevalim I'll have a look if I can reproduce it there. 👍

[josevalim]

@maennchen I noticed this fell through my cracks. The offer still stands if you are game. :)

[maennchen]

@josevalim it also fell through my cracks. I'll have a look next week since I'm currently on vacation.