Skip to content

Don't time out when running the extract task#417

Merged
whatyouhide merged 3 commits into
elixir-gettext:mainfrom
thoroai:fix/extract-timeout
Jul 28, 2025
Merged

Don't time out when running the extract task#417
whatyouhide merged 3 commits into
elixir-gettext:mainfrom
thoroai:fix/extract-timeout

Conversation

@jhosteny

Copy link
Copy Markdown
Contributor

Set a timeout of :infinity when running extract. This is in line with the setting for the merge operation.

Fixes #416

Set a timeout of :infinity when running extract. This is in line with
the setting for the merge operation.

Fixes #416
@whatyouhide

Copy link
Copy Markdown
Contributor

I’m now considering that :infinity is risky for CI systems and whatnot. I think a better approach would be a sensible timeout of something like 2 minutes or so?

@jhosteny

Copy link
Copy Markdown
Contributor Author

Hi @whatyouhide, sure! I pushed another commit with that change. Note that that are two other uses of :infinity for task timeouts. I didn't change those, since I am not sure if a timeout of 120s is currently ever being exceeded for those. In this case, merging this would relax the timeout from 5s to 120s, so it seems safer.

@whatyouhide

Copy link
Copy Markdown
Contributor

@jhosteny can you run mix format as well please?

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 3ebab4208a4879f1c1f22d7c522e48c1bc09e92c-PR-417

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.518%

Totals Coverage Status
Change from base Build fc89178eb34933b909b3e78a2441308cbf13ecfc: 0.0%
Covered Lines: 643
Relevant Lines: 695

💛 - Coveralls

@whatyouhide whatyouhide merged commit 54ccc9c into elixir-gettext:main Jul 28, 2025
3 checks passed
@whatyouhide

Copy link
Copy Markdown
Contributor

Thank you @jhosteny 💟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Timeout running "mix gettext.extract --merge"

3 participants