Add new function put_locale!/2 #420
Merged
maennchen merged 2 commits intoSep 5, 2025
Merged
Conversation
abdelhalim97
force-pushed
the
abdelhalim97/add-put_locale!
branch
from
3cc444b to
b015158
Compare
Contributor
|
@maennchen thoughts here? I’m ok with this. |
maennchen
reviewed
Sep 2, 2025
Member
|
@abdelhalim97 Thanks for the PR ❤️ @whatyouhide Besides the small nit above, this looks like a good improvement. |
Pull Request Test Coverage Report for Build 8af5c394b96ab515b8b4784ae9b945b640af52cb-PR-420Details
💛 - Coveralls |
abdelhalim97
force-pushed
the
abdelhalim97/add-put_locale!
branch
from
b015158 to
8af5c39
Compare
Contributor
Author
|
Done 🫡 |
maennchen
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
put_locale/2put_locale!/2inspired fromput_locale/2only difference that if unsupported locale is introduced it wil raise errorImportant
Got constructive feedback from this PR