Extract File menu into a component

[Gaurav0]

Relevant to issue #127

[rwjblue]

Thank you, I definitely like this! A few tweaks:

• Can you swap the internalAction="someActionFromControlleR" and this.sendAction usage for the newer style closure actions?
• Can you split up the test a bit (I'd like to see a separate test for each action)?

[Gaurav0]

@rwjblue Updated. Some of the actions could not be made into closure actions because they bubble to the route.

[rwjblue]

Can you tweak these to save to this? Something like:

this.on('addFile', (type) => { this.addFileCalled = true; this.fileType = type; });

Then you can assert in the tests below like:

assert.ok(this.addFileCalled, 'addFile was called');
assert.equal(this.fileType, 'template', 'addFile was called with type parameter');

---

Using the above, will help us ensure that there is no leakage between tests. Say we add a test in the future that also triggers an action, the boolean xyzCalled may have already been set causing the tests to be not quite right.

[Gaurav0]

@rwjblue Updated again as per request.

[rwjblue]

This is totally fine as is, but removing these would result in the same test (since this.addFileCalled would be undefined and not truthy the assertions would still pass).

[rwjblue]

👍 - Sorry to be such an annoying reviewer, but thanks for working so hard on this!