add component (both js and hbs) Add File choice#148
Merged
Gaurav0 merged 4 commits intoember-cli:masterfrom Aug 15, 2015
Merged
add component (both js and hbs) Add File choice#148Gaurav0 merged 4 commits intoember-cli:masterfrom
Gaurav0 merged 4 commits intoember-cli:masterfrom
Conversation
Member
There was a problem hiding this comment.
Might want to make it slightly kinder 😈
Contributor
There was a problem hiding this comment.
@rwjblue @joostdevries Do we want an error message at all or do we want to automatically strip the extension?
Contributor
Author
There was a problem hiding this comment.
@Gaurav0 @rwjblue @joostdevries imagine most of the time people will want to do what stripping accomplishes, so despite my affection for the snarky msg, gonna strip the extension if no objections
Contributor
|
You have a jshint error, and you have some conflicts. |
Contributor
|
@kagemusha This looks great! Can you do the following:
|
Contributor
Author
|
@Gaurav0 added. pls take a look. |
Contributor
|
👍 |
Gaurav0
added a commit
that referenced
this pull request
Aug 15, 2015
add component (both js and hbs) Add File choice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes care of issue #35.
One difference from discussions there is that if user enters file extension, get snarky error msg instead of stripping it off :-), but this can be changed if the latter felt better.
Tests to come.