Skip to content

better title input#159

Merged
Gaurav0 merged 2 commits intoember-cli:masterfrom
KTKate:master
Aug 18, 2015
Merged

better title input#159
Gaurav0 merged 2 commits intoember-cli:masterfrom
KTKate:master

Conversation

@KTKate
Copy link
Copy Markdown
Contributor

@KTKate KTKate commented Aug 18, 2015

press enter to focus out
clear default text on focus in
replace default text on focus out

clear default text on focus in
Comment thread app/components/title-input.js Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please fix indentation. It looks like the function ends here.
  2. Won't this delete a title that isn't the default text?

@KTKate
Copy link
Copy Markdown
Contributor Author

KTKate commented Aug 18, 2015

I intended it to clear everything because regardless of what's in there it's annoying to have to backspace before you can type but on 2nd thought I just selected the existing text so it could be easily overwritten but not destroyed.

@Gaurav0
Copy link
Copy Markdown
Contributor

Gaurav0 commented Aug 18, 2015

Works for me! 👍

Gaurav0 added a commit that referenced this pull request Aug 18, 2015
@Gaurav0 Gaurav0 merged commit 51c021b into ember-cli:master Aug 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants