better sign in that fixes #183 & hack that fixes #187 ....again#190
better sign in that fixes #183 & hack that fixes #187 ....again#190Gaurav0 merged 3 commits intoember-cli:masterfrom
Conversation
|
looks great |
|
Haha as soon as I submitted the PR I realized that would have been better. I'll change it. |
There was a problem hiding this comment.
Adding a space here won't fix it if the user changes the name.
There was a problem hiding this comment.
Hm, I wasn't aware the problem happened when the title had been changed. Even if the named has been changed and then later reverted back to New Twiddle. Please show steps to reproduce a once edited title getting cut off.
There was a problem hiding this comment.
So you have to
- Change the title
- Save the gist
- Load Ember Twiddle with the saved gist.
There was a problem hiding this comment.
I tried that before and just tried it again and the title was not cut off. I tried it both logged in and logged out. This issue is unpredictable enough it's almost like a practical joke!
There was a problem hiding this comment.
Yes, I know. Sorry. Maybe instead of adding a space to the value you can add a space to a computed property based on value and show that?
3 participants
Current
### This PRI moved the github icon to the right because it looked disjointed on the left somehow. Once signed in, the user's avatar is unchanged.