Add possibility to copy own twiddle#215
Merged
rwjblue merged 1 commit intoember-cli:masterfrom Oct 12, 2015
pangratz:copy-own-twiddle
Merged
Add possibility to copy own twiddle#215rwjblue merged 1 commit intoember-cli:masterfrom pangratz:copy-own-twiddle
rwjblue merged 1 commit intoember-cli:masterfrom
pangratz:copy-own-twiddle
Conversation
If a gist owned by the authenticated user is shown, a new menu item "Copy Twiddle" allows to copy the current files into a new Twiddle. Note that the newly created Twiddle is not yet saved. By this, Twiddles (e.g. Ember setup for a specific version) can be used as a starting point without having to re-setup the whole Twiddle again and again.
Member
|
👍 - LGTM |
rwjblue
added a commit
that referenced
this pull request
Oct 12, 2015
Add possibility to copy own twiddle
Contributor
Author
|
Aaaand it's live on http://canary.ember-twiddle.com. Oh boy, this workflow is awesome! 👯 |
Closed
Contributor
Author
There was a problem hiding this comment.
Thx! But it currently misses assertions that all files have been copied correctly. Do you have any suggestions? Would it be sufficient to run the twiddle and check if the output is the same as the original one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a gist owned by the authenticated user is shown, a new menu item
"Copy Twiddle" allows to copy the current files into a new Twiddle. Note
that the newly created Twiddle is not yet saved.
By this, Twiddles (e.g. Ember setup for a specific version) can be used
as a starting point without having to re-setup the whole Twiddle again
and again.
This addresses #78 and #157 (comment).