Overhaul /twiddles#229
Merged
rwjblue merged 3 commits intoember-cli:masterfrom Oct 24, 2015
pangratz:overhaul-twiddles
Merged
Conversation
This makes the look of /twiddles consistent with the other parts of Ember Twiddle. The rendered file menu only contains the "New Twiddle" menu item, which creates a new twiddle.
Contributor
|
This looks really great. I think we just need a few more tests. Specifically, user-menu component should have a test around the show twiddles action. Also maybe an acceptance test for New Twiddle coming from /twiddles. |
This menu item is used to navigate to the list of saved twiddles.
Contributor
Author
|
@Gaurav0 done. Thanks for the review! |
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the look of
/twiddlesconsistent with the other look by rendering the toolbar. Also, the user menu now has a link which navigates to the/twiddlesroute.Before
After
Added My Saved Twiddles menu item in user menu
In action