Merged
Conversation
This PR also adds a way to replace arbitrary properties in the blueprint content when calling `buildProperties` in the emberCLI service.
Contributor
There was a problem hiding this comment.
I think this method should get a unit test.
Contributor
Author
|
@Gaurav0 I added the unit test. Let me know if you need anything else. |
Contributor
Author
There was a problem hiding this comment.
I could see the addFile method being more like this in the future.
knownasilya
force-pushed
the
helper-blueprint
branch
from
ee203be to
328d497
Compare
Contributor
|
See Travis CI Build. It thinks you are missing a semicolon. |
knownasilya
force-pushed
the
helper-blueprint
branch
from
328d497 to
81014a3
Compare
knownasilya
force-pushed
the
helper-blueprint
branch
from
81014a3 to
377c1b9
Compare
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR also adds a way to replace arbitrary properties in the blueprint
content when calling
buildPropertiesin the emberCLI service.Closes #191
Thanks @SaladFork for your Services PR, which I used to bounce off of.