Fix failing tests#241
Merged
Gaurav0 merged 2 commits intoember-cli:masterfrom Oct 26, 2015
pangratz:fix-failing-tests
Merged
Conversation
Test are failing locally due to runloop issues with ember-autoresize.
And empty string is not a valid JSON. This caused the "visiting /twiddles" acceptance test to throw an error at the end of the test (where the clicked twiddle is shown). This somehow hasn't been caught as an error, but it is shown in the console of the Web Inspector.
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executing the tests locally threw an error due to run-loop issues with
ember-resize. This has been fixed upstream in adopted-ember-addons/ember-autoresize#26.Parsing an empty string for
twiddle.jsonthrows an error at the end of thevisting /twiddlesacceptance test, which somehow isn't failing the test but the error is logged in the console of Web Inspector.