Link to GH release page of current version#255
Merged
rwjblue merged 1 commit intoember-cli:masterfrom Oct 28, 2015
pangratz:change-link-in-help-menu
Merged
Link to GH release page of current version#255rwjblue merged 1 commit intoember-cli:masterfrom pangratz:change-link-in-help-menu
rwjblue merged 1 commit intoember-cli:masterfrom
pangratz:change-link-in-help-menu
Conversation
Contributor
|
I think it should at least be possible to provide an alternate link in canary and development. |
Contributor
Author
|
It could be the link to the specific commit in canary, but I am unsure what this should be in development. Maybe remove the item when in development? Or use https://github.com/ember-cli/ember-twiddle? |
Contributor
Author
|
I updated the No version link is shown when in
Link to commit is shown when in
Link to release is shown when in
|
- no link is shown when in development - link to latest commit when in staging (aka canary) - link to release notes when in production
rwjblue
added a commit
that referenced
this pull request
Oct 28, 2015
Link to GH release page of current version
Member
|
😍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the link in the help menu to point to the release notes of the current version. Example: https://github.com/ember-cli/ember-twiddle/releases/tag/0.4.14
Note that the link will be broken in canary and in development, but I think that is acceptable...