Skip to content

Specify open files via query paramter#296

Merged
alexspeller merged 1 commit intoember-cli:masterfrom
Gaurav0:open_files
Dec 17, 2015
Merged

Specify open files via query paramter#296
alexspeller merged 1 commit intoember-cli:masterfrom
Gaurav0:open_files

Conversation

@Gaurav0
Copy link
Copy Markdown
Contributor

@Gaurav0 Gaurav0 commented Dec 17, 2015

This is for issue #123.

@stefanpenner
Copy link
Copy Markdown
Contributor

Should link-to that changes the query param open then files in question? Or is that out of scope

@Gaurav0
Copy link
Copy Markdown
Contributor Author

Gaurav0 commented Dec 17, 2015

@stefanpenner I think that should already work. Let me check.

@Gaurav0
Copy link
Copy Markdown
Contributor Author

Gaurav0 commented Dec 17, 2015

@stefanpenner A link-to within the outer application does indeed open the files. You can't do it from the twiddle itself, though. And I think that is ok.

@stefanpenner
Copy link
Copy Markdown
Contributor

@stefanpenner A link-to within the outer application does indeed open the files. You can't do it from the twiddle itself, though. And I think that is ok.

👍 sounds great, this lgtm.

@alexspeller
Copy link
Copy Markdown
Member

🎉

alexspeller added a commit that referenced this pull request Dec 17, 2015
Specify open files via query paramter
@alexspeller alexspeller merged commit 7e6739a into ember-cli:master Dec 17, 2015
@Gaurav0 Gaurav0 deleted the open_files branch March 21, 2016 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants