Fix navigation reload

[piotrpalek]

This fixes issue #290, but it depends on these changes to codemirror.

[piotrpalek]

I've (temporarily) changed the CodeMirror dependency to the modified version so tests will pass on Travis.

[piotrpalek]

I changed contentsChanged on the file-editor-column component, it didn't make sense that contentsChanged wouldn't fire when the content in the column actually changed. Now the gist controller gets to decide what to do depending on a flag the new action fires.

[Gaurav0]

I think you need to change the test description to match the new behavior.

[piotrpalek]

I'm on mobile now so I could miss something, but what do you mean? The description is correct(imo) on the main test method above, and this assertion would say that it expected a true value (if it would fail). Did you mean to add that it expects a true value in this assertion?

[Gaurav0]

Instead of "contentChanged action was called", "contentChanged was called with isUserChange=true"

[piotrpalek]

Ah sure, I thought the title would be enough but I'll add it

[Gaurav0]

This looks really good! Just need to fix up minor nits.

[rwjblue]

It's ok if we can't, but I'd much prefer to make sure the upstream changes land before merging.

[Gaurav0]

Yes, please at least open a PR.

[piotrpalek]

Sure will do, it was just so you can see that the tests actually pass :)

[piotrpalek]

I've made a PR to CodeMirror

[piotrpalek]

Changes landed upstream so I updated package.json to reflect that, if everything is all right should I rebase to a single commit?

[Gaurav0]

No need, and actually I'm not a fan of rewriting history.

[Gaurav0]

👍

[piotrpalek]

👍