Skip to content

Ability to load a previous revision of a gist#340

Merged
Gaurav0 merged 4 commits intoember-cli:masterfrom
Gaurav0:revision_route
Mar 3, 2016
Merged

Ability to load a previous revision of a gist#340
Gaurav0 merged 4 commits intoember-cli:masterfrom
Gaurav0:revision_route

Conversation

@Gaurav0
Copy link
Copy Markdown
Contributor

@Gaurav0 Gaurav0 commented Mar 1, 2016

Issue #66

Comment thread tests/acceptance/git-revision-test.js Outdated
];

runGist({
type: "revision",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it looks weird to have a function called runGist which you can then pass an optional flag to run something else. Why not create runGistRevision?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it is weird. I did it because they were the mostly the same. I'll adjust. Thanks!

Gaurav0 added a commit that referenced this pull request Mar 3, 2016
Ability to load a previous revision of a gist
@Gaurav0 Gaurav0 merged commit 45bf9e5 into ember-cli:master Mar 3, 2016
@Gaurav0 Gaurav0 deleted the revision_route branch March 3, 2016 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants