Skip to content

updated header style#378

Merged
Gaurav0 merged 3 commits intoember-cli:masterfrom
davidpett:new-header-style
Apr 3, 2016
Merged

updated header style#378
Gaurav0 merged 3 commits intoember-cli:masterfrom
davidpett:new-header-style

Conversation

@davidpett
Copy link
Copy Markdown

aligns style to emberjs.com, fixes #377

@rwjblue
Copy link
Copy Markdown
Member

rwjblue commented Apr 2, 2016

Would you mind sharing a screenshot/gif/etc to show what it looks like?

@davidpett
Copy link
Copy Markdown
Author

I will post when I am back on the computer, maybe not until Monday, but I am referencing the same background image on http://emberjs.com and the same font treatment as well

Comment thread app/styles/_toolbar.scss Outdated
-webkit-box-shadow: rgba(0,0,0,0.3) 0 0 3px;
box-shadow: rgba(0,0,0,0.3) 0 0 3px;
background: $ember-orange;
background-image: url("//emberjs.com/images/header.svg");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please download and include this image in build. This will cause a mixed content warning in production as emberjs.com does not use https.

@davidpett
Copy link
Copy Markdown
Author

Screenshots

Desktop

screen shot 2016-04-03 at 8 43 01 am

Mobile

screen shot 2016-04-03 at 8 43 39 am

Mobile with menu open

screen shot 2016-04-03 at 8 43 53 am

@rwjblue
Copy link
Copy Markdown
Member

rwjblue commented Apr 3, 2016

Awesome, thank you!

@davidpett
Copy link
Copy Markdown
Author

@Gaurav0, fixed

@Gaurav0
Copy link
Copy Markdown
Contributor

Gaurav0 commented Apr 3, 2016

👍

@Gaurav0 Gaurav0 merged commit 279a7c3 into ember-cli:master Apr 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Responsive Header needs design love

3 participants