Change app name to twiddle

[Gaurav0]

No description provided.

[joostdevries]

lgtm

[rwjblue]

Hmm. Does this break the addon processing? I suspect that it needs to build the addons with the same app name...

If it doesn't break then have we ensured that the cache of prebuilt addons is cleared?

[joostdevries]

@rwjblue that's the reason for the change ;-) The backend now uses twiddle as app name since app was not allowed as name by ember-cli.

[rwjblue]

@joostdevries - And the cache of prebuilt addons was cleared?

[joostdevries]

@rwjblue Yes. Because the build process was completely refactored to use docker instead of lambda (allowing git deps and muuuch faster build times and lower costs).

joostdevries/twiddle-backend#2

[alexspeller]

Wait, am I missing something or will this break all existing twiddled that
have imports in them for local modules?
On Tue, 12 Apr 2016 at 14:37, Robert Jackson notifications@github.com
wrote:

@joostdevries https://github.com/joostdevries - And the cache of
prebuilt addons was cleared?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#394 (comment)

[joostdevries]

@alexspeller the name was recently changed from demo-app to app so that breakage was already present at that point AFAIK.

[rwjblue]

We should detect the twiddle.json version, and use the appropriate name.

[joostdevries]

@rwjblue agreed but prefer to track that in isolated issue since breakage was already introduced.

[Gaurav0]

@alexspeller It doesn't break imports that use relative urls. We never made 'demo-app' name public.

[joostdevries]

@rwjblue #41

[rwjblue]

so that breakage was already present at that point AFAIK

The change from demo-app to app was over 10 days ago (released in https://github.com/ember-cli/ember-twiddle/releases/tag/v0.7.2 5 days ago). Anyone bit by this, likely now has to deal with this twice.

This tool is a large community resource, and should follow the same guidelines on breakages as Ember itself. The change to app should have been reverted as soon as it was clear that this broke existing twiddles and the solution I proposed (and you created #41 to track) should have been implemented before introducing yet another breaking change.

[joostdevries]

@rwjblue agreed. Let's hold off on releasing untill we fix #41

[joostdevries]

or revert to demo-app

[joostdevries]

@Gaurav0 we could also just do a very simple replace(/demo-app/g, "twiddle") in the UI only I guess