adding github enterprise support#507
Merged
Gaurav0 merged 1 commit intoember-cli:masterfrom Jan 9, 2017
Merged
Conversation
Contributor
|
Looks good but I have no way of testing this on a GHE instance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to add github enterprise support so that ember-twiddle can be run privately if required.
Basically, this PR just replaces hard coded strings with reading from environmental variables. I new torii provider for github enterprise was added because the baseUrl and redirectUrl are different for github enterprise distributions.
I talked to @Gaurav0 about this months ago. Takes me a while to get PRs up due to company policy.